Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"New file" link from Welcome page presents selector that "New File" from File menu doesn't #105825

Closed
gjsjohnmurray opened this issue Sep 1, 2020 · 2 comments
Closed

"New file" link from Welcome page presents selector that "New File" from File menu doesn't #105825

gjsjohnmurray opened this issue Sep 1, 2020 · 2 comments
Assignees
@rebornix @mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone
August 2020

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Bug

image

This selector does not appear whan I use File\New File or its Ctrl+N shortcut.

Is this difference intentional?

VS Code version: Code - Insiders 1.49.0-insider (b6d4fec, 2020-09-01T05:54:42.740Z)
OS version: Windows_NT x64 10.0.18363
@bpasero bpasero assigned mjbvz and chrmarti and unassigned bpasero Sep 1, 2020
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-welcome Welcome page issues labels Sep 1, 2020
@bpasero
Copy link
Member

bpasero commented Sep 1, 2020

This does not look good to me, but I am not sure where this originates from, adding @chrmarti for welcome and @mjbvz for custom editors.

@bpasero bpasero assigned rebornix and unassigned chrmarti Sep 1, 2020
@bpasero bpasero closed this as completed in 7686b52 Sep 1, 2020
@bpasero bpasero added workbench-editors Managing of editor widgets in workbench window and removed workbench-welcome Welcome page issues labels Sep 1, 2020
@bpasero bpasero added this to the August 2020 milestone Sep 1, 2020
@bpasero
Copy link
Member

bpasero commented Sep 1, 2020

@rebornix fyi I think a regression from one of your changes, you check on args to get a viewtype but there can be other args passed to this command and I think we only want to go into this picker when a viewtype is provided. Please check my fix in 7686b52

@jrieken jrieken added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
7 participants
@rebornix @bpasero @jrieken @gjsjohnmurray @chrmarti @mjbvz and others