New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up cell output debt #105846
Comments
This one relates the renderer work @connor4312 is doing now. If the output renderers are all pure and lives in the webview, then we don't need |
Yea, I can clean these up this month. |
@connor4312 Can you/we tackle those debt items before going all-in on the new API and such? |
@rebornix @roblourens I have created #110855 which removes the transform logic and moves that into a single place |
Sure, I should have time this month to tack some of that |
Hi, finally have some unallocated time to do this 🙂 Before I just in, I know you have been working on hammering out the final versions of these APIs. Does that work affect this cleanup, or can I go ahead and take care of this tomorrow? |
Please hold back or join us in #115817 |
We are done with this |
Some debt has accumulated around cell output and we should start to clean things up
transformEditsOutputs
andtransformSpliceOutputs
which feel like they are on the wrong layer, e.g should this be part of the serialisation of outputIProcessedOutput
which also seems wrongly placed. Maybe the internal model object specs all the data of those two and the API types are directly converted into those typesoutputKind
-marker is an api-alien conceptThe text was updated successfully, but these errors were encountered: