Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename on Type: linked edit mode is terminated when the tag becomes empty #105860

Closed
ornelladotcom opened this issue Sep 1, 2020 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@ornelladotcom
Copy link

ornelladotcom commented Sep 1, 2020

Testing #105760

renameontype

Repro:
on macOS
set Rename on Type to true in both user and workspace
Create HTML file
Try changing opening tag

Didn't see any syncing happening, I also tried changing the closing tag and did not see syncing.

@ornelladotcom
Copy link
Author

ornelladotcom commented Sep 1, 2020

It did work for me when I highlighted the entire tag name and typed in a new tag name. It also worked when pasting in a character into the middle of the tag name.

For undo, it required two undos if my cursor was still within the tag name, but if I clicked out, it worked with one undo.

@aeschli
Copy link
Contributor

aeschli commented Sep 1, 2020

In the screencast, when you delete head you see that the closing tag is modified as well.
But it's a bug that the sync mode ends once the tag is empty. I'll look at that.

@egamma egamma changed the title Rename on Type not working on macOS Rename on Type: linked edit mode is terminated when the tag becomes empty Sep 2, 2020
@aeschli aeschli added this to the August 2020 milestone Sep 2, 2020
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug html HTML support issues labels Sep 2, 2020
@aeschli aeschli closed this as completed in 8aa9dbc Sep 2, 2020
@rebornix rebornix added the verified Verification succeeded label Sep 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@rebornix @aeschli @ornelladotcom and others