Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive playground eats arrow keys #105935

Open
jrieken opened this issue Sep 2, 2020 · 1 comment
Open

Interactive playground eats arrow keys #105935

jrieken opened this issue Sep 2, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug interactive-playground
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Sep 2, 2020

Wasn't able to reproduce but it went like this

  • had the welcome page showing
  • went into a TS file
  • trigger peek references, up/down arrows don't work to navigate in tree
  • enable trace log and see this KeybindingService#dispatch ↓ workbench.action.interactivePlayground.arrowDown

So, there must be something wrong with its context key definition but I can't say how it happened...

[2020-09-02 12:58:13.865] [renderer3] [trace] CommandService#executeCommand workbench.action.interactivePlayground.arrowUp
[2020-09-02 12:58:13.865] [renderer3] [trace] telemetry/workbenchActionExecuted {"id":"workbench.action.interactivePlayground.arrowUp","from":"keybinding"}
[2020-09-02 12:58:15.778] [renderer3] [trace] KeybindingService#dispatch ↓ workbench.action.interactivePlayground.arrowDown
[2020-09-02 12:58:15.778] [renderer3] [trace] CommandService#executeCommand workbench.action.interactivePlayground.arrowDown
[2020-09-02 12:58:15.778] [renderer3] [trace] telemetry/workbenchActionExecuted {"id":"workbench.action.interactivePlayground.arrowDown","from":"keybinding"}
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug workbench-welcome Welcome page issues labels Sep 3, 2020
@chrmarti chrmarti added this to the September 2020 milestone Sep 3, 2020
@ivanjonas
Copy link

ivanjonas commented Sep 9, 2020

I have a possibly related scenario:

  • Did not have the welcome page anywhere.
  • Opened a .ts file showing.
  • Triggered "Peek References".

Result:
✅ Up/down arrows work.
✅ Pressing enter to expand/collapse a file works.
❌ Pressing enter to navigate to a line does not work.
✅ Double-clicking to navigate to a line does work.

@chrmarti chrmarti modified the milestones: September 2020, October 2020 Oct 1, 2020
@chrmarti chrmarti modified the milestones: October 2020, November 2020 Oct 30, 2020
@chrmarti chrmarti modified the milestones: January 2021, February 2021 Jan 27, 2021
@chrmarti chrmarti modified the milestones: February 2021, March 2021 Feb 19, 2021
@chrmarti chrmarti modified the milestones: March 2021, Backlog Mar 22, 2021
@JacksonKearl JacksonKearl added interactive-playground and removed workbench-welcome Welcome page issues labels Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug interactive-playground
Projects
None yet
Development

No branches or pull requests

4 participants