Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings sync - multiple error dialogs #105936

Closed
lszomoru opened this issue Sep 2, 2020 · 0 comments
Closed

Settings sync - multiple error dialogs #105936

lszomoru opened this issue Sep 2, 2020 · 0 comments
Assignees
@sandy081
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue settings-sync
Milestone
August 2020

Comments

@lszomoru
Copy link
Member

lszomoru commented Sep 2, 2020

If an error occurs (ex: auth provider API) while turning on settings sync for the first time on a machine, we are displaying two error notifications without a clear message of what the error has been. We should only show one error notification with a better error message.
@sandy081 sandy081 added the polish Cleanup and polish issue label Sep 2, 2020
@sandy081 sandy081 added this to the August 2020 milestone Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue settings-sync
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
3 participants
@lszomoru @sandy081 and others