Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cell doesn't show up in diff view #105959

Closed
sana-ajani opened this issue Sep 2, 2020 · 2 comments
Closed

New cell doesn't show up in diff view #105959

sana-ajani opened this issue Sep 2, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded

Comments

@sana-ajani
Copy link
Contributor

Testing #105770

Open a notebook file and insert a cell in between two cells and save, and open diff view. The last cell does not show up in the right side of the diff view (even if I make a change in the last cell).

recording (9)

@sana-ajani sana-ajani changed the title New cell in between cells doesn't show up in diff view New cell doesn't show up in diff view Sep 2, 2020
@rebornix
Copy link
Member

rebornix commented Sep 2, 2020

/duplicate of #105778

@rebornix rebornix closed this as completed Sep 2, 2020
@rebornix rebornix reopened this Sep 11, 2020
@rebornix rebornix added notebook bug Issue identified by VS Code Team member as probable bug and removed *duplicate Issue identified as a duplicate of another issue(s) labels Sep 11, 2020
@rebornix rebornix added this to the September 2020 milestone Sep 11, 2020
@rebornix
Copy link
Member

Regressed when doing the text model / editing refactoring, now fixed again with via 59dcc5c

@connor4312 connor4312 added the verified Verification succeeded label Oct 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@rebornix @connor4312 @sana-ajani and others