Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook diff editor model does not call super.dispose() #106008

Closed
bpasero opened this issue Sep 3, 2020 · 0 comments
Closed

Notebook diff editor model does not call super.dispose() #106008

bpasero opened this issue Sep 3, 2020 · 0 comments
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 3, 2020

This is dangerous as the parent type has some state associated when it gets disposed:

@bpasero bpasero added debt Code quality issues notebook labels Sep 3, 2020
@rebornix rebornix added this to the August 2020 milestone Sep 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook
Projects
None yet
Development

No branches or pull requests

3 participants
@rebornix @bpasero and others