Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] JSON language server not localized #106220

Closed
PhoebeTf opened this issue Sep 7, 2020 · 4 comments
Closed

[json] JSON language server not localized #106220

PhoebeTf opened this issue Sep 7, 2020 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality json JSON support issues
Milestone

Comments

@PhoebeTf
Copy link
Member

PhoebeTf commented Sep 7, 2020

VSCode Version: VSCode 1.48.2

Steps to Reproduce:
1.Install VSCode
2.Install Language Extension Chinese(Simplified) and C++ extension
3.Open file “c_cpp_properties.json”
4. Delete the value or update value to an invalid one for property "cStandard"
5. Check the warning info in tooltip window

Expected:
Warning info in tooltip window

Actual:
Warning string “Value expected” and “Value is not accepted. Valid values" in file “c_cpp_properties.json” is not localized in tooltip window
(Repro on Windows, Linux and Mac)
image

image

@vscodebot
Copy link

vscodebot bot commented Sep 7, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@weinand weinand added the *caused-by-extension Issue identified to be caused by an extension label Sep 7, 2020
@PhoebeTf
Copy link
Member Author

PhoebeTf commented Sep 9, 2020

@weinand Sorry for mislead you when create this issue, this issue actually not related C++ Extension, as when we delete a value or update value to invalid one for VSCode property without C++ extension installed, issue still repro (Updated screenshot as below), could you help to double check this issue? Thanks.

Warning string “Value expected” in file “settings.json” is not localized in tooltip window
valueEx

Warning string “Value is not accepted. Valid values" in file “settings.json” is not localized in tooltip window
value_valids

@weinand weinand removed the *caused-by-extension Issue identified to be caused by an extension label Sep 9, 2020
@weinand weinand reopened this Sep 9, 2020
@PhoebeTf PhoebeTf changed the title Warning string “Value expected” and “Value is not accepted. Valid values" in file “c_cpp_properties.json” is not localized Warning string “Value expected” and “Value is not accepted. Valid values" in json file is not localized Sep 9, 2020
@aeschli aeschli changed the title Warning string “Value expected” and “Value is not accepted. Valid values" in json file is not localized [json] validation errors not localized Sep 9, 2020
@aeschli aeschli added json JSON support issues feature-request Request for new features or functionality labels Sep 9, 2020
@aeschli aeschli added this to the Backlog milestone Sep 9, 2020
@aeschli aeschli changed the title [json] validation errors not localized [json] JSON language server not localized Sep 10, 2020
@v-ericawu
Copy link

"Trailing comma" in file “c_cpp_properties.json” is not localized:
image

@PhoebeTf
Copy link
Member Author

PhoebeTf commented Jun 6, 2024

Tested with VSCode 1.89.1 and C++ extension v1.20.5, this issue has been fixed. So close it.
image

@PhoebeTf PhoebeTf closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality json JSON support issues
Projects
None yet
Development

No branches or pull requests

5 participants
@weinand @aeschli @PhoebeTf @v-ericawu and others