Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open editors view: context keys are very generic #106246

Closed
bpasero opened this issue Sep 7, 2020 · 2 comments
Closed

Open editors view: context keys are very generic #106246

bpasero opened this issue Sep 7, 2020 · 2 comments
Assignees
Labels
context-keys file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders

Comments

@bpasero
Copy link
Member

bpasero commented Sep 7, 2020

While going through some of the editor related context keys I noticed that the "Open Editors" view seems to define very generic keys that might confuse users, such as:

  • readonlyEditor
  • dirtyEditor

I feel these should make clear what they are, because they seem to reflect the state of the selected editor in the open editors view and not the active editor that is opened. I suggest to rename to better reflect their source if possible.

@bpasero bpasero added file-explorer Explorer widget issues context-keys labels Sep 7, 2020
@isidorn isidorn closed this as completed in 707ce44 Sep 8, 2020
@isidorn
Copy link
Contributor

isidorn commented Sep 8, 2020

This makes sense. I have renamed them to

  • readonlyEditorFocusedInOpenEditors
  • dirtyEditorFocusedInOpenEditors

They were never exposed in docs or api so it is fine to rename.

@isidorn isidorn added this to the September 2020 milestone Sep 8, 2020
@bpasero
Copy link
Member Author

bpasero commented Sep 8, 2020

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
context-keys file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @isidorn and others