Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter codicon is not visible #106829

Closed
sandy081 opened this issue Sep 16, 2020 · 5 comments
Closed

Filter codicon is not visible #106829

sandy081 opened this issue Sep 16, 2020 · 5 comments
Assignees
@eamodio
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
September 2020

Comments

@sandy081
Copy link
Member

image
@sandy081
Copy link
Member Author

Also in problems view

@miguelsolorio
Copy link
Contributor

Seems like the class is applied accordingly:

vscode/src/vs/workbench/contrib/extensions/browser/extensionsViewlet.ts

Line 543 in 9097605

new SubmenuAction('workbench.extensions.action.filterExtensions', localize('filterExtensions', "Filter Extensions..."), filterActions, 'codicon-filter'),

But the - in the class is being stripped out:

image

image

@eamodio did you say you saw something similar with subemenu actions? This feels like it's related to SubmenuAction.

@eamodio
Copy link
Contributor

eamodio commented Sep 16, 2020

I don't think this is related to the fix that I made here: 0eee546

@eamodio eamodio assigned eamodio and unassigned miguelsolorio Sep 16, 2020
@eamodio eamodio added the bug Issue identified by VS Code Team member as probable bug label Sep 16, 2020
@eamodio eamodio added this to the September 2020 milestone Sep 16, 2020
@miguelsolorio
Copy link
Contributor

Thanks @eamodio for fixing. Looks like this was caused via 863acba (fyi @joaomoreno)

@joaomoreno
Copy link
Member

Ooof should've seen that one coming. Thanks for the fix @eamodio. We really got to stop having multiple class names in a single string. #103454 (comment)

@bpasero bpasero added the verified Verification succeeded label Oct 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
September 2020
Development

No branches or pull requests
6 participants
@joaomoreno @eamodio @bpasero @sandy081 @miguelsolorio and others