Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug hover's maximum size is too small #106865

Closed
weinand opened this issue Sep 16, 2020 · 6 comments
Closed

debug hover's maximum size is too small #106865

weinand opened this issue Sep 16, 2020 · 6 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan

Comments

@weinand
Copy link
Contributor

weinand commented Sep 16, 2020

debug hover is too small and doesn't allow for horizontal scrolling:

2020-09-16_16-45-35

The hover window must adapt its size to the data that needs to be shown (within some limits).
If the size would exceed the limits, scrolling needs to be possible.

@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Sep 16, 2020
@weinand
Copy link
Contributor Author

weinand commented Sep 16, 2020

I take it back: scrolling is possible.
But the default maximum size of the hover is just too tiny.
As long as the hover window stays within the bounds of the underlying VS Code window, it could use any size.

@weinand weinand changed the title debug hover is too small and doesn't allow for horizontal scrolling debug hover's maximum size is too small Sep 16, 2020
@isidorn
Copy link
Contributor

isidorn commented Sep 16, 2020

What a coincidence just today I have assigned this bug to September with the idea to investigate furhter
Due to that closign this as duplicate of #43326

Idealy the hover should be resizable

@isidorn isidorn closed this as completed Sep 16, 2020
@weinand
Copy link
Contributor Author

weinand commented Sep 16, 2020

@isidorn I only agree, if you mean "automatic resizability". Manual resizability is just clumsy.

I don't want to resize hovers manually just to see the end of string.
If there is enough space on my screen to fully show the string in the hover, why should I resize the hover when VS Code can do this for me automatically?

In addition, what is the semantics of resizing? Is the size remembered for the next hover (where it might be too big and just looks ugly)? Or do I have to resize every time?

And then there is the problem that interactions with hovers are delicate because interacting with the hover's border will easily dismiss it.

As previously said, I suggest to make the hover fit its contents as long as the hover window stays within the bounds of the underlying VS Code window. And if the hover needs to become larger, there is scrolling.

@weinand weinand reopened this Sep 16, 2020
@isidorn
Copy link
Contributor

isidorn commented Sep 17, 2020

Makes sense and I agree with your points. Let's assign to September for investigation.

@isidorn isidorn added this to the September 2020 milestone Sep 17, 2020
@isidorn
Copy link
Contributor

isidorn commented Sep 17, 2020

I have fined tuned the debug hover width and height to the following:

  • Height is as large as needed up to the maximum of the 70% editor content height. Once max is hit there is the scroll bar.
  • Width is as large as needed up to the maximum of 700px. Once max is hit, there is the scroll bar.

I have tried it out and works quite nice for me. Please try it out and let me know how it goes.

@isidorn
Copy link
Contributor

isidorn commented Sep 21, 2020

This item is covered by this test plan item #107156

@isidorn isidorn added feature-request Request for new features or functionality on-testplan and removed bug Issue identified by VS Code Team member as probable bug labels Sep 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

No branches or pull requests

3 participants
@weinand @isidorn and others