Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks returned from fetchTasks do not contain dependsOn information #106946

Closed
bwateratmsft opened this issue Sep 17, 2020 · 6 comments
Closed

Tasks returned from fetchTasks do not contain dependsOn information #106946

bwateratmsft opened this issue Sep 17, 2020 · 6 comments
Assignees
Labels
api api-proposal feature-request Request for new features or functionality tasks Task system issues

Comments

@bwateratmsft
Copy link
Contributor

  • VSCode Version: 1.49.0
  • OS Version: Win10 10.0.19041

Steps to Reproduce:

  1. Create a task that uses the dependsOn property to depend on another task
  2. In extension code, call vscode.tasks.fetchTasks()

Expected:
Task returned would contain all information including dependsOn

Actual:
Task has name and definition, and a few other properties, but does not have dependsOn

Does this issue occur when all extensions are disabled?: N/A

@bwateratmsft
Copy link
Contributor Author

@alexr00 FYI

@alexr00 alexr00 self-assigned this Sep 23, 2020
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Sep 29, 2020
@alexr00 alexr00 added this to the October 2020 milestone Sep 29, 2020
@alexr00 alexr00 modified the milestones: October 2020, November 2020 Oct 27, 2020
@alexr00 alexr00 added feature-request Request for new features or functionality api api-proposal and removed bug Issue identified by VS Code Team member as probable bug labels Nov 12, 2020
@alexr00
Copy link
Member

alexr00 commented Nov 12, 2020

I thought that we already dependsOn in the API, but it looks like we don't.

@bwateratmsft
Copy link
Contributor Author

Yeah, this is where there was a difference between the config API and the fetchTasks API. As part of our Docker build / run / debug process, we need to build up a task tree, in order to "find" the docker-build / docker-run tasks. Knowing information from those tasks allows us to save a significant amount of time and reduce the complexity of the launch.json and tasks.json files.

So far we've been using the config API which works fine in most cases, but when using workspaces instead of workspace folders, it starts to break down.

I have a work item to switch to mostly/entirely resolveDebugConfigurationWithSubstitutedVariables(); because this runs after the tasks instead of before, it might eliminate the need for building the task tree. I haven't done enough investigation to be sure though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-proposal feature-request Request for new features or functionality tasks Task system issues
Projects
None yet
Development

No branches or pull requests

3 participants
@bwateratmsft @alexr00 and others