Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview copy/paste shortcuts broken in 1.50-insiders #107309

Closed
joyceerhl opened this issue Sep 23, 2020 · 6 comments
Closed

Webview copy/paste shortcuts broken in 1.50-insiders #107309

joyceerhl opened this issue Sep 23, 2020 · 6 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders webview Webview issues

Comments

@joyceerhl
Copy link
Contributor

Version: 1.50.0-insider
Commit: f943318
Date: 2020-09-23T05:28:07.760Z (11 hrs ago)
Electron: 9.3.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 18.7.0

Steps to Reproduce:

  1. Download the vscode extension samples (https://github.com/microsoft/vscode-extension-samples.git)
  2. Modify the html in the cat coding webview sample to have a <input>
  3. Run the cat coding webview
  4. Type some text into the text area, select it, and try to ctrl+c / ctrl+v

Ctrl+c doesn't write to the clipboard, and ctrl+v has no effect.

This is causing https://github.com/microsoft/vscode-python/issues/14053 in the Python extension. I was on 1.48-insiders right before updating to repro this with our customer's setup, and this bug was not present in that build.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Sep 23, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@mjbvz
Copy link
Contributor

mjbvz commented Sep 23, 2020

Do you see it in 1.49 as well?

@mjbvz mjbvz added this to the September 2020 milestone Sep 23, 2020
@mjbvz mjbvz added the webview Webview issues label Sep 23, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Sep 23, 2020

Actually, pretty simple fix. I suspect it's in 1.49 too but not on web (and not with iframe based webviews on desktop)

@mjbvz mjbvz closed this as completed in 74679be Sep 23, 2020
@joyceerhl
Copy link
Contributor Author

@mjbvz, do you know when this fix will become available in insiders? I see that this issue is tagged released, but we had another customer report the same issue 4 days ago: https://github.com/microsoft/vscode-python/issues/14095, and I still repro the problem locally. Thanks so much 😊

@mjbvz
Copy link
Contributor

mjbvz commented Sep 29, 2020

I just tested using 772aa07 on Mac and Windows and it seems to be fine. Can you verify you are on that build and that copy/paste doesn't work in the sample extension specifically

@joyceerhl
Copy link
Contributor Author

Ah yes it seems to work fine with the sample extension. Thanks Matt!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders webview Webview issues
Projects
None yet
Development

No branches or pull requests

3 participants
@mjbvz @joyceerhl and others