Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot focus closed markdown cell when focus lost #107581

Open
webczat opened this issue Sep 28, 2020 · 9 comments
Open

Cannot focus closed markdown cell when focus lost #107581

webczat opened this issue Sep 28, 2020 · 9 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues debt Code quality issues notebook-accessibility notebook-markdown
Milestone

Comments

@webczat
Copy link

webczat commented Sep 28, 2020

Version: 1.50.0-insider
Commit: 403a689
Date: 2020-09-18T07:13:12.194Z
Electron: 9.3.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Linux x64 5.8.10-arch1-1

It seems to me that I cannot focus closed markdown cells, or it is not accessible with screenreader.
I created both markdown and c# cells, closed both of them and lost focus by tabbing around. I cannot return to the markdown editor or go directly to the rendered markdown, at least screenreader in browse mode does not see it is there. if I'd switch back to focus/forms mode, I cannot also press arrows and move between cells. However if I press tab long enough I seem to be able to land on the c# cell. If I remove this c# cell I cannot focus anything like cell list or rendered output of markdown cell, only browse mode seems to help at least when wanting to see the output.
CC: @isidorn

@vscodebot
Copy link

vscodebot bot commented Sep 28, 2020

@isidorn
Copy link
Contributor

isidorn commented Sep 28, 2020

Related discussion #93896

Forwarding to @rebornix and @roblourens for Notebook

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues notebook labels Sep 28, 2020
@roblourens
Copy link
Member

Moving focus around the cell list should work basically the same as other lists in vscode, and the logic for editing cells is the same as in the new settings editor: enter should put the markdown cell back in edit mode and put focus in the editor. And escape moves focus back to the list and gets rid of the editor in a markdown cell.

When you say you "closed" the cells, what do you mean exactly?

@webczat
Copy link
Author

webczat commented Sep 28, 2020

the thing was I cannot refocus the list when I leave it, for example if I'd close all cells (means, press esc on all of them) then go to explorer, how would I go back... :) In markdown case tab does not reach markdown cell if it is not in edit mode

@roblourens
Copy link
Member

I can tab back from the explorer to the list. The list gets focus and then I can continue navigating with arrow keys. It should be a tab target like other lists.

@webczat
Copy link
Author

webczat commented Sep 29, 2020

how is that announced with a screenreader? I will likely download newest insiders and retry.

@roblourens
Copy link
Member

I'm not sure, is something announced for this when focusing other lists?

@webczat
Copy link
Author

webczat commented Sep 29, 2020

yes. but that is not exactly the question as I cannot say whether I focus the list but can't figure that out because accessibility is broken, or I don't focus the list because I have too old insiders or I do something wrong. so trying to actually figure that out

@roblourens
Copy link
Member

When I focus the explorer, it just reads the focused row. When I focus a notebook row, it only reads "and one more item and 2 more items, group" which is definitely not useful.

@rebornix rebornix added this to the October 2020 milestone Oct 5, 2020
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Oct 7, 2020
@rebornix rebornix modified the milestones: October 2020, On Deck Oct 26, 2020
@rebornix rebornix added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Nov 4, 2020
@rebornix rebornix removed the notebook label Oct 21, 2021
@rebornix rebornix removed their assignment Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues debt Code quality issues notebook-accessibility notebook-markdown
Projects
None yet
Development

No branches or pull requests

5 participants