Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New search results cleared after search-and-replace operation finishes #107806

Open
t-schroeder opened this issue Sep 30, 2020 · 1 comment
Open
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member search Search widget and operation issues
Milestone

Comments

@t-schroeder
Copy link

t-schroeder commented Sep 30, 2020

  • VSCode Version:

Version: 1.49.2 (user setup)
Commit: e5e9e69
Date: 2020-09-24T16:29:41.983Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

  • OS Version: Windows 10 2004
  • Remote OS Version: CentOS 7

Steps to Reproduce:

  1. Use Remote SSH extension to connect to another machine.
  2. Open a large project with thousands of files.
  3. Do a search-and-replace that affects over a thousand files.
  4. While the changed files are being saved perform a new search.
  5. As soon as the last file is saved (from the replace operation started in step 3) the results of the new search get cleared.
  6. You have to hit <Enter> again to run your new search again.

Does this issue occur when all extensions are disabled?: Can't test this as I'm using the Remote SSH extension

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Sep 30, 2020
@roblourens roblourens added this to the Backlog milestone Sep 30, 2020
@roblourens
Copy link
Member

We should probably not allow doing a new search before the replace has finished

@roblourens roblourens modified the milestones: Backlog, On Deck Dec 13, 2022
@andreamah andreamah assigned andreamah and unassigned roblourens Dec 15, 2022
@andreamah andreamah added the confirmed Issue has been confirmed by VS Code Team member label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

3 participants