Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scmViewPane: do not render whitespace in commit message input field #107913

Merged
merged 1 commit into from Nov 10, 2020
Merged

scmViewPane: do not render whitespace in commit message input field #107913

merged 1 commit into from Nov 10, 2020

Conversation

rupran
Copy link
Contributor

@rupran rupran commented Oct 1, 2020

When entering a commit message we don't need to render whitespace, so let's disable the corresponding option in the editorOptions hash.

This PR fixes #107689

@roblourens roblourens mentioned this pull request Oct 1, 2020
Closed
@rupran
Copy link
Contributor Author

rupran commented Oct 2, 2020 •
edited

I'm not really sure about the test failure, is there something I missed?

Update: it seems that the initial run for the VS Code executed successfully (here), and the failed test was later triggered from another test pull request (this one) and got linked back into this one.

@rupran
scmViewPane: do not render whitespace in commit message input field
111966f 
When entering a commit message we don't need to render
whitespace, so let's disable the corresponding option in the
editorOptions hash.

Fixes: #107689
@rupran
Copy link
Contributor Author

rupran commented Nov 9, 2020

Just checking if I need to do anything else: is there need to rebase to the current master and pass the test suite?

@joaomoreno joaomoreno added this to the November 2020 milestone Nov 10, 2020
@joaomoreno
Copy link
Member

Thanks!

@joaomoreno joaomoreno merged commit 9b0522f into microsoft:master Nov 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.

SCM commit message should have it's own whitespace color or be configurable not to highlight whitespace
2 participants
@rupran @joaomoreno