Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM suggest widget is behind editor #109221

Open
jrieken opened this issue Oct 23, 2020 · 6 comments
Open

SCM suggest widget is behind editor #109221

jrieken opened this issue Oct 23, 2020 · 6 comments
Assignees
@joaomoreno @lszomoru
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities safari Issues running VSCode in Web on Safari scm General SCM compound issues
Milestone
Backlog

Comments

@jrieken
Copy link
Member

jrieken commented Oct 23, 2020 •
edited

  • use safari
  • trigger suggest in SCM view
  • 馃悰 the widget is behind the editor

Screenshot 2020-10-23 at 10 54 01
@jrieken jrieken added the safari Issues running VSCode in Web on Safari label Oct 23, 2020
@joaomoreno
Copy link
Member

@jrieken Can you repro on other browsers? I don't have a macOS machine, so I take any help I can here.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities scm General SCM compound issues labels Oct 23, 2020
@joaomoreno joaomoreno added this to the Backlog milestone Oct 23, 2020
@jrieken
Copy link
Member Author

jrieken commented Oct 23, 2020

Screenshot 2020-10-23 at 14 29 49

@lszomoru lszomoru self-assigned this Oct 4, 2021
@lszomoru
Copy link
Member

lszomoru commented Dec 9, 2022

@alexdima, @hediet, is there an editor setting that I am missing or this is an editor issue with Safari? Thanks!

@alexdima
Copy link
Member

alexdima commented Dec 9, 2022 •
edited

I think this might be a z-index problem. Perhaps the workbench editor area has a z-index greater than the z-index of the suggest widget? If you have a repro, is there any improvement by adding something like z-index: 100000 to the suggest widget dom node?

@lszomoru
Copy link
Member

lszomoru commented Dec 9, 2022

Will give that a try and let you know. What's interesting is that I can only repro in Safari.

@lszomoru
Copy link
Member

Related to 149f31e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

@lszomoru lszomoru

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities safari Issues running VSCode in Web on Safari scm General SCM compound issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@joaomoreno @jrieken @lszomoru @alexdima