Fixes cannot disable file auto save when configuration target is other than user

[jeanp413]

This PR fixes #108932

[bpasero]

@jeanp413 thanks, this change made me look closer into the configurationService.updateValue method. As you can see, it seems to already do exactly what you do manually from within the implementation when you leave out the target:

vscode/src/vs/workbench/services/configuration/browser/configurationService.ts

Lines 710 to 735 in 8fcf778

	private deriveConfigurationTarget(key: string, value: any, overrides: IConfigurationOverrides | undefined, target: ConfigurationTarget): ConfigurationTarget | undefined {
	if (target) {
	return target;
	}
	if (value === undefined) {
	// Ignore. But expected is to remove the value from all targets
	return undefined;
	}
	const inspect = this.inspect(key, overrides);
	if (equals(value, inspect.value)) {
	// No change. So ignore.
	return undefined;
	}
	if (inspect.workspaceFolderValue !== undefined) {
	return ConfigurationTarget.WORKSPACE_FOLDER;
	}
	if (inspect.workspaceValue !== undefined) {
	return ConfigurationTarget.WORKSPACE;
	}
	return ConfigurationTarget.USER;
	}

I actually think that we should not have code outside the configuration service that tries to find the right target, it should be handled consistently within the configuration service.

@sandy081 need your advice here: searching for references to ConfigurationTarget.USER I see a ton of uses, e.g. in the editor to toggle things, such as minimap:

vscode/src/vs/workbench/contrib/codeEditor/browser/toggleMinimap.ts

Lines 26 to 29 in f345453

	public run(): Promise<any> {
	const newValue = !this._configurationService.getValue<boolean>('editor.minimap.enabled');
	return this._configurationService.updateValue('editor.minimap.enabled', newValue, ConfigurationTarget.USER);
	}

If a user has configured the editor.minimap.enabled setting as a workspace setting, these actions actually do nothing.

To summarise, I think the auto save toggle is just the tip of the ice berg, any updateValue with ConfigurationTarget.USER will fail unless the setting is not allowed per workspace.

[jeanp413]

Removed the duplicated code, let me know if fixing the other places that you pointed out will be part of this pr or will be tackle apart.

[bpasero]

Thanks, I have extracted #109373 for follow up on the other locations.

[sandy081]

As a core service IConfigurationService provides multiple options for the consumer to update - like updating in specific target or resource etc., Its up to the caller to use the variant it needed. I agree that most of the toggle actions does not need to send the target and just use the updateValue(key, value) and the service does the right thing.