Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed shebang same as code.sh #109372

Merged
merged 4 commits into from Oct 30, 2020
Merged

Changed shebang same as code.sh #109372

merged 4 commits into from Oct 30, 2020

Conversation

RakibFiha
Copy link
Contributor

This PR fixes ##74929

The two different shebang can point to two different bash, specially in MacOS.

@ghost
Copy link

ghost commented Oct 26, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2020

@joaomoreno just getting a second opinion as we run these all the time.

@joaomoreno
Copy link
Member

Yeah this is the right way.

@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Oct 30, 2020
@joaomoreno joaomoreno merged commit 7670c0c into microsoft:master Oct 30, 2020
@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno added this to the October 2020 milestone Oct 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants