Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winpty-agent.exe is different for each VSCode version #109465

Closed
lucamanga opened this issue Oct 27, 2020 · 3 comments
Closed

winpty-agent.exe is different for each VSCode version #109465

lucamanga opened this issue Oct 27, 2020 · 3 comments
Assignees
Labels

Comments

@lucamanga
Copy link

lucamanga commented Oct 27, 2020

The problem is that we have a Group Policy to restrict the access to executables.
The policy permits the user to execute all executables in "C:\Program Files".
The problem is that Visual Studio Code tries to run an executable from this strange path:

"\?\C:\Program Files\Microsoft VS Code...."

we must write new hash file of winpyh-agent.exe that is submitted on each VSCode version.

Could you remove that initial "\?" ?

  • VSCode Version: 1.50.1 (but affects earlier versions, too)
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open Terminal
  2. An error popus: "The terminal process failed to launch: A native exception occurred during launch (Error launching WinPTY agent: winpty-agent CreateProcess failed: cmdline='"\?\C:\Program Files\Microsoft VS Code\resources\app\node_modules.asar.unpacked\node-pty\build\Release\winpty-agent.exe"

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Oct 27, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@lucamanga
Copy link
Author

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

* [TS Server fatal error:  Debug Failure. (#106004)](https://www.github.com/microsoft/vscode/issues/106004)

* [TS Server fatal error:  Debug Failure. (#108025)](https://www.github.com/microsoft/vscode/issues/108025)

* [TS Server fatal error:  Debug Failure. (#107065)](https://www.github.com/microsoft/vscode/issues/107065)

* [TS Server fatal error:  Maximum call stack size exceeded (#105605)](https://www.github.com/microsoft/vscode/issues/105605)

None of these. It is not an error, it is a Group Policy of our organization that limits the run of executables from strange paths.
The temporary fix is to insert the hash code of the Winpty-agent.exe, but this is not too comfortable (we should update it at EVERY vscode release)

@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2020

Sorry that's a legacy feature and we're not changing how it ships at this point. If you're on Windows 1903+ the recommendation is to move off this anyway as the default for terminal.integrated.windowsEnableConpty is true.

@Tyriar Tyriar closed this as completed Oct 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants