Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal.integrated.typeaheadThreshold naming #109585

Closed
Tyriar opened this issue Oct 28, 2020 · 2 comments
Closed

terminal.integrated.typeaheadThreshold naming #109585

Tyriar opened this issue Oct 28, 2020 · 2 comments
Assignees
@Tyriar @connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues terminal-local-echo Relating to the terminal's local echo and line editing for remote windows verified Verification succeeded
Milestone
October 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2020

Type ahead was always just a quick codename/internal name for the feature. I think we should name this terminal.integrated.latencyMitigationThreshold.
@Tyriar Tyriar added polish Cleanup and polish issue terminal Integrated terminal issues labels Oct 28, 2020
@Tyriar Tyriar added the terminal-local-echo Relating to the terminal's local echo and line editing for remote windows label Oct 28, 2020
@connor4312
Copy link
Member

latencyMitigationStyle or latencyMitigationCharacterStyle reads awkwardly to me. "Latency mitigation" sounds like a process, where something like "typeahead" sounds like concrete feature. Maybe keep the typeahead name and change the setting to typeaheadLatencyThreshold?

@Tyriar
Copy link
Member Author

Tyriar commented Oct 28, 2020 •
edited

Actually local echo or local line editing are typical names for this features like this, how about that localEchoLatencyThreshold/localLineEditingLatencyThreshold? Would make it more discoverable than type ahead which is pretty ambiguous.

@Tyriar Tyriar added this to the October 2020 milestone Oct 28, 2020
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Oct 28, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues terminal-local-echo Relating to the terminal's local echo and line editing for remote windows verified Verification succeeded
Projects
None yet
Milestone
October 2020
Development

No branches or pull requests
4 participants
@Tyriar @connor4312 @rzhao271 and others