Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal.integrated.typeaheadStyle could have more friendly values #109590

Closed
Tyriar opened this issue Oct 28, 2020 · 2 comments
Closed

terminal.integrated.typeaheadStyle could have more friendly values #109590

Tyriar opened this issue Oct 28, 2020 · 2 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues terminal-local-echo Relating to the terminal's local echo and line editing for remote windows
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2020

Some of the possible values right now aren't useful imo like invert, bold, maybe italic too as the predictions will end up looking quite different to what will replace it. I suggest we change it to: 'normal' | 'dim' | 'underline' and colors. This also hides internal details like the style codes from the user.

@Tyriar Tyriar added polish Cleanup and polish issue terminal Integrated terminal issues labels Oct 28, 2020
@Tyriar Tyriar added the terminal-local-echo Relating to the terminal's local echo and line editing for remote windows label Oct 28, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Oct 28, 2020

@connor4312 do you think it's worth keeping bold and inverted in there too? They look pretty clunky and probably won't ever see use?

@Tyriar Tyriar added this to the October 2020 milestone Oct 28, 2020
@connor4312
Copy link
Member

I could imagine vision impaired users may prefer the visible inverted style over the more subtle dim/underline options. Making them available is cheap enough imo.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues terminal-local-echo Relating to the terminal's local echo and line editing for remote windows
Projects
None yet
Development

No branches or pull requests

3 participants
@Tyriar @connor4312 and others