Allow monaco-editor to work propertly with Jest #109833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node.js environments where Jest is run,
global
is already an existing variable. Usingconst
to redeclare it causes an error and therefore makes it impossible to run anymonaco-editor
related tests with Jest. Changing this line fromconst
tovar
doesn't cause this issue.We use
monaco-editor
in GitLab, and in order to upgrade it to the latest version and make it work with Jest, the only solution was to patch it usingpatch-package
. The patch solution doesn't scale so well.Here's a bit more info: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46436#note_438312326