Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace color theme setting not picked up on remote #109966

Merged
merged 4 commits into from Nov 5, 2020
Merged

workspace color theme setting not picked up on remote #109966

merged 4 commits into from Nov 5, 2020

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Nov 4, 2020 •
edited

This PR fixes #101893

  • before reading the settings, wait for the EH to be up
  • listen to settings/extension while setting the first theme
  • sequence the setting and reloading of themes.

@aeschli aeschli added the themes Color theme issues label Nov 4, 2020
@aeschli aeschli added this to the November 2020 milestone Nov 4, 2020
@aeschli aeschli self-assigned this Nov 4, 2020
@aeschli aeschli merged commit 22c2bad into master Nov 5, 2020
@aeschli aeschli deleted the aeschli/remoteThemeFix branch November 5, 2020 09:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
themes Color theme issues
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.

Remote: workspace color theme setting does not override default on startup
1 participant
@aeschli