Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added outline offset to checkbox to make focus visible. #110038

Merged
merged 3 commits into from Nov 5, 2020
Merged

Added outline offset to checkbox to make focus visible. #110038

merged 3 commits into from Nov 5, 2020

Conversation

aasimkhan30
Copy link
Contributor

@aasimkhan30 aasimkhan30 commented Nov 5, 2020 •
edited

This PR fixes #110037

Before:
image

After:
image

miguelsolorio
miguelsolorio suggested changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just a minor suggested change (important isn't necessary here).

src/vs/workbench/browser/media/style.css Outdated Show resolved Hide resolved
@miguelsolorio miguelsolorio added this to the November 2020 milestone Nov 5, 2020
@miguelsolorio miguelsolorio merged commit 48ebbe9 into microsoft:master Nov 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miguelsolorio miguelsolorio miguelsolorio approved these changes

Assignees

@miguelsolorio miguelsolorio

Labels
None yet
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.

Checkbox focus not visible on welcome screen
2 participants
@aasimkhan30 @miguelsolorio