Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Git: Push Tags command #110096

Merged
merged 1 commit into from Nov 9, 2020
Merged

feat: implement Git: Push Tags command #110096

merged 1 commit into from Nov 9, 2020

Conversation

stdavis
Copy link
Contributor

@stdavis stdavis commented Nov 6, 2020

This implements the new command mentioned in #109799. To test, create a new tag and run the command: "Git: Push Tags".

I haven't yet added (or even investigated) tests. I'd love any direction on what needs to happen in this regard.

This PR fixes #109799

@ghost
Copy link

ghost commented Nov 6, 2020 •
edited by ghost

CLA assistant check
All CLA requirements met.

rheh
rheh reviewed Nov 6, 2020
View reviewed changes
Copy link

@rheh rheh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGMT.

Should git.test.ts be updated to include a new unit test for the change?

@stdavis
Copy link
Contributor Author

stdavis commented Nov 6, 2020 •
edited

Should git.test.ts be updated to include a new unit test for the change?

I've been looking at the pushWithTags command for clues and haven't found any tests referencing that or any sort of push function/method including in git.test.ts.

But thanks for the review!

@joaomoreno joaomoreno added the git GIT issues label Nov 9, 2020
@joaomoreno
Copy link
Member

No need for tests! 👍

@joaomoreno joaomoreno marked this pull request as ready for review November 9, 2020 14:56
@joaomoreno joaomoreno added this to the November 2020 milestone Nov 9, 2020
@joaomoreno joaomoreno merged commit 7e5609a into microsoft:master Nov 9, 2020
@joaomoreno
Copy link
Member

Looks great, thanks! 🍻

@stdavis stdavis deleted the push-tags branch November 9, 2020 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rheh rheh rheh approved these changes

Assignees

@joaomoreno joaomoreno

Labels
git GIT issues
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.

Git: Support Git: Push Tags command
3 participants
@stdavis @joaomoreno @rheh