WorkspaceFileEditOptions add maxSize #111042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheh
reviewed
Nov 20, 2020
| } catch (err) { | ||
| this._logService.critical(err); | ||
| } | ||
| } | ||
|
|
||
| const useTrash = this._fileService.hasCapability(this.oldUri, FileSystemProviderCapabilities.Trash) && this._configurationService.getValue<boolean>('files.enableTrash'); | ||
| await this._workingCopyFileService.delete([this.oldUri], { useTrash, recursive: this.options.recursive, ...this.undoRedoInfo }); | ||
| return this._instaService.createInstance(CreateOperation, this.oldUri, this.options, { isUndoing: true }, contents); | ||
|
|
||
| if (typeof this.options.maxSize === 'number' && fileContent && (fileContent?.size > this.options.maxSize)) { |
There was a problem hiding this comment.
Suggestion: move to two new private functions so it is reusable and easier to read e.g.
if (this->hasMaxFileSize() && this._doesSizeExceedMax(fileContent)) { return new Noop(); }
| } catch (err) { | ||
| this._logService.critical(err); | ||
| } | ||
| } | ||
|
|
||
| const useTrash = this._fileService.hasCapability(this.oldUri, FileSystemProviderCapabilities.Trash) && this._configurationService.getValue<boolean>('files.enableTrash'); | ||
| await this._workingCopyFileService.delete([this.oldUri], { useTrash, recursive: this.options.recursive, ...this.undoRedoInfo }); | ||
| return this._instaService.createInstance(CreateOperation, this.oldUri, this.options, { isUndoing: true }, contents); | ||
|
|
||
| if (typeof this.options.maxSize === 'number' && fileContent && (fileContent?.size > this.options.maxSize)) { |
There was a problem hiding this comment.
nit pick: Braces around last condition not required.
There was a problem hiding this comment.
Thanks for the suggestoin. This way it is more readable for me.
| if (!this._undoesCreateOperation && !this.options.folder) { | ||
| try { | ||
| contents = (await this._fileService.readFile(this.oldUri)).value; | ||
| fileContent = (await this._fileService.readFile(this.oldUri)); |
There was a problem hiding this comment.
nit pick: braces around await not required.
There was a problem hiding this comment.
Makes sense. I will change that. Copy / paste error.
jrieken
approved these changes
Nov 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
maxSizeoption to theWorkspaceFileEditOptions.We need to limit how large a file we keep in memory, otherwise this can grow unbounded.
The idea is that Explorer would use this API to limit file sizes that we keep in memory to 5mb.
Corner case: what if the user deletes ten 9mb files. Thea each file is below the limit but will still take up space all together.
I think we can live with this limitation for now, and potentially the
UndoRedoservice could limit the number of items to 20 always.fyi @alexdima who also came up with the idea of this approach