Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected label cropping in ports view #111378

Closed
jrieken opened this issue Nov 26, 2020 · 7 comments
Closed

Unexpected label cropping in ports view #111378

jrieken opened this issue Nov 26, 2020 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality remote-explorer Remote explorer view verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Nov 26, 2020

  • use @egamma's express sample
  • run the start script
  • check the ports view
  • 馃槙 the actual link shouldn't be cropped, esp not when there is so much space

Screenshot 2020-11-26 at 18 28 55

@alexr00
Copy link
Member

alexr00 commented Nov 27, 2020

@jrieken I have gotten specific feedback from many sources that this link must be shortened! What do you gain by having the uuid visible?

@jrieken
Copy link
Member Author

jrieken commented Nov 27, 2020

I wanna know what the uri is and it shouldn't be hidden. Today, I need to either open it or copy/paste - both not very friendly. Also, there is now enough space to show a long'ish url so I don't know how much of the "old" feedback is still valid

@alexr00
Copy link
Member

alexr00 commented Nov 27, 2020

The old feedback wasn't that the url was too long, it was that it was too scary. I personally am not afraid of long urls, but I do not feel like I need to know what the whole url is (I'm not going to do anything with the knowledge of what the url is), which means that it is a lot of meaningless characters to show.

@alexr00 alexr00 added under-discussion Issue is under discussion for relevance, priority, approach remote-explorer Remote explorer view labels Nov 27, 2020
@alexr00
Copy link
Member

alexr00 commented Nov 27, 2020

That said, I'll make some screenshots of both and share them around.

@alexr00 alexr00 added this to the December/January 2021 milestone Nov 27, 2020
@alexr00 alexr00 modified the milestones: January 2021, February 2021 Jan 19, 2021
@alexr00
Copy link
Member

alexr00 commented Feb 11, 2021

Further discussion showed that most people want to have the whole URL when the view is in the panel.

@alexr00 alexr00 added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Feb 11, 2021
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Feb 22, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Feb 24, 2021
@rzhao271
Copy link
Contributor

Wondering whether the cropping should only occur when it's in the panel (compared to the sidebar)?

express-example

@rzhao271 rzhao271 reopened this Feb 24, 2021
@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Feb 24, 2021
@alexr00
Copy link
Member

alexr00 commented Feb 25, 2021

All address cropping has been removed. Only regular overflow behavior with the ellipse is done (as shown in the screen shot).

@alexr00 alexr00 closed this as completed Feb 25, 2021
@alexr00 alexr00 removed the verification-found Issue verification failed label Feb 25, 2021
@lszomoru lszomoru added the verified Verification succeeded label Feb 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality remote-explorer Remote explorer view verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@jrieken @lszomoru @rzhao271 @alexr00 and others