Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable shm usage in container builds #111787

Merged
merged 4 commits into from Dec 9, 2020
Merged

fix: disable shm usage in container builds #111787

merged 4 commits into from Dec 9, 2020

Conversation

deepak1556
Copy link
Contributor

Fixes #111729

@deepak1556 deepak1556 added this to the November 2020 milestone Dec 3, 2020
@deepak1556 deepak1556 mentioned this pull request Dec 3, 2020
Closed
@deepak1556 deepak1556 force-pushed the robo/disable_shm branch 4 times, most recently from 826f5b9 to 1033b38 Compare December 4, 2020 07:43
@joaomoreno
Copy link
Member

Build is failing: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=96161&view=logs&j=4d2898ab-dfbe-557e-92e7-aaac158fdd2f&t=bf591f68-b11f-58a5-2795-b482f67ba1e7

@joaomoreno
Copy link
Member

Also before merging this, we should really be sure of the bionic update.

@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Dec 4, 2020
@deepak1556
Copy link
Contributor Author

Build is failing: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=96161&view=logs&j=4d2898ab-dfbe-557e-92e7-aaac158fdd2f&t=bf591f68-b11f-58a5-2795-b482f67ba1e7

Oops the xvfb step is not needed, container establishes it.

Also before merging this, we should really be sure of the bionic update.

Yup. Although image is bionic, it now uses older gcc toolchain to maintain compatibility. Got some early testing happening here microsoft/vscode-remote-release#4103

@joaomoreno
Copy link
Member

joaomoreno commented Dec 7, 2020 •
edited

@deepak1556 Now the integration tests fail mysteriously: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=96200&view=logs&j=4d2898ab-dfbe-557e-92e7-aaac158fdd2f&t=a099afca-dbc0-5987-bf48-8950ed3c0139&l=198

@deepak1556
Copy link
Contributor Author

failing due to, looking into it.

[2498:1204/180442.771943:ERROR:viz_main_impl.cc(152)] Exiting GPU process due to errors during initialization

[2473:1204/180442.939298:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.login1.Manager.Inhibit: object_path= /org/freedesktop/login1: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.PolicyKit1 was not provided by any .service files

@joaomoreno
Copy link
Member

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=96408&view=logs&j=4d2898ab-dfbe-557e-92e7-aaac158fdd2f&t=2d4939b1-2b74-59b7-3eb2-605f0910a1a9

🥳

@deepak1556
Copy link
Contributor Author

Looks like hw compositing is not available

[2886:1208/083944.049321:ERROR:gl_surface_egl.cc(725)] No suitable EGL configs found.
[2886:1208/083944.049435:ERROR:gl_surface_egl.cc(773)] EGL Driver message (Error) eglGetConfigAttrib: Bad config.
[2886:1208/083944.049468:ERROR:gl_context_egl.cc(95)] eglGetConfigAttrib failed with error EGL_BAD_CONFIG
[2886:1208/083944.049579:ERROR:gl_surface_egl.cc(725)] No suitable EGL configs found.
[2886:1208/083944.049616:ERROR:gl_surface_egl.cc(773)] EGL Driver message (Error) eglCreatePbufferSurface: Bad config.
[2886:1208/083944.049642:ERROR:gl_surface_egl.cc(2076)] eglCreatePbufferSurface failed with error EGL_BAD_CONFIG
[2886:1208/083944.049666:ERROR:gpu_info_collector.cc(65)] gl::GLContext::CreateOffscreenGLSurface failed
[2886:1208/083944.049690:ERROR:gpu_info_collector.cc(273)] Could not create surface for info collection.
[2886:1208/083944.049716:ERROR:gpu_init.cc(77)] CollectGraphicsInfo failed.
[2886:1208/083944.052240:ERROR:viz_main_impl.cc(150)] Exiting GPU process due to errors during initialization
[2894:1208/083944.102557:ERROR:command_buffer_proxy_impl.cc(122)] ContextResult::kTransientFailure: Failed to send GpuChannelMsg_CreateCommandBuffer.

Let me fix that before we merge this.

@deepak1556
Copy link
Contributor Author

@joaomoreno this is ready for review, shm and gpu issue logs have been cleared https://monacotools.visualstudio.com/Monaco/_build/results?buildId=96465&view=results

@deepak1556 deepak1556 merged commit daca95e into master Dec 9, 2020
@deepak1556 deepak1556 deleted the robo/disable_shm branch December 9, 2020 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno Awaiting requested review from joaomoreno

Assignees

@joaomoreno joaomoreno

@deepak1556 deepak1556

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.

Build: Fix Linux integration tests
2 participants
@deepak1556 @joaomoreno