Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not touch current line's indentation when pressing Enter #111897

Merged
merged 1 commit into from Dec 8, 2020

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Dec 4, 2020

Fixes #111128

Changing the leading indentation on the current line is interfering with multiple cursors, so I suggest that we remove that, which I believe happens to also be a fix for #61510 , but I leave closing #61510 with this change up to you.

@alexdima alexdima self-assigned this Dec 4, 2020
@alexdima alexdima added this to the December/January 2021 milestone Dec 4, 2020
@rebornix rebornix self-assigned this Dec 4, 2020
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rebornix
Copy link
Member

rebornix commented Dec 8, 2020

As we discussed offline, the indentation of current line is controlled by the content of previous lines and current line (before cursor) so it's uncommon that users press enter in the middle of a line and expect the indentation of current line and the new line being adjusted. It doesn't mean that case doesn't exist, but it's rare.

@alexdima alexdima merged commit 71ba241 into master Dec 8, 2020
@alexdima alexdima deleted the alex/111128 branch December 8, 2020 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multicursor Enter issue with indentation (gif attached)
2 participants