Do not ignore errors from $spawnExtHostProcess #112033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a similar issue with the $startExtensionTerminal below in the code. |
Tyriar
reviewed
Jan 6, 2021
|
@Tyriar It made errors where it was impossible to open shell due to errors/exceptions, much more visible. Instead of showing 'Starting...', it shows error message, which gives more troubleshooting info. For example, it made it easy to diagnose errors like this: #76542 (comment) (It can't get access to parent process env for some reason). |
Tyriar
approved these changes
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback from the request accepts error as well as undefined. However, we ignore error, when we call then. This change fixes it.