Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the root typings for keytar since we are loading the root node module #112798

Merged
merged 1 commit into from Dec 18, 2020

Conversation

alexdima
Copy link
Member

For #112718

----------------------------------
size saving: 1.84%
file count saving: 1.58%
----------------------------------
PATH                                             BYTES      FILES
root                                       732,186,870     36,295
build                                      172,837,622     11,452
remote                                     172,606,391      1,759
extensions/typescript-language-features     64,892,021        735
test/smoke                                  63,022,613      5,024
test/automation                             60,712,649      4,728
test/integration/browser                    53,567,321        484
extensions                                  30,564,829         84
extensions/html-language-features/server     6,260,414        414
extensions/emmet                             6,230,887        438
remote/web                                   5,728,559        267
extensions/css-language-features/server      4,721,109        335
extensions/markdown-language-features        4,697,992      1,136
extensions/git                               4,542,196        405
extensions/microsoft-authentication          4,445,327        662
extensions/github                            4,186,258        399
extensions/json-language-features            3,492,388        682
extensions/json-language-features/server     2,921,100        418
extensions/html-language-features            2,860,474        563
extensions/github-authentication             2,790,450        466
extensions/npm                               2,564,903        399
extensions/extension-editing                 2,218,244        249
extensions/css-language-features             1,978,164        323
build/lib/watch                              1,249,570        512
extensions/image-preview                       881,680        235
extensions/configuration-editing               846,610         72
extensions/vscode-colorize-tests               821,302         66
extensions/vscode-custom-editor-tests          719,021         71
extensions/vscode-notebook-tests               696,288         54
extensions/debug-auto-launch                   678,927         56
extensions/debug-server-ready                  678,927         56
extensions/grunt                               678,927         56
extensions/gulp                                678,927         56
extensions/jake                                678,927         56
extensions/merge-conflict                      678,927         56
extensions/php-language-features               678,927         56
extensions/vscode-api-tests                    666,633         54
extensions/git-ui                              654,993         50
extensions/vscode-test-resolver                654,993         50
TOTAL                                    1,421,972,360     69,273

@alexdima alexdima self-assigned this Dec 18, 2020
@alexdima alexdima merged commit 65c59b5 into master Dec 18, 2020
@alexdima alexdima deleted the alex/node-modules-types-keytar branch December 18, 2020 09:56
@alexdima alexdima added the engineering VS Code - Build / issue tracking / etc. label Dec 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant