Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in open editors view #11287

Closed
isidorn opened this issue Aug 31, 2016 · 6 comments
Closed

Icons in open editors view #11287

isidorn opened this issue Aug 31, 2016 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 31, 2016

Refs: #11130

Steps to Reproduce:

  1. Enable icon theme
  2. Notice there are no icons in the open editors view. I find this strange, especially with the seti theme, as the users eyes might get used to a particular icon when finding a file, and that approach will not work in the open editors view

Opinions @bpasero?

@isidorn isidorn added feature-request Request for new features or functionality themes Color theme issues labels Aug 31, 2016
@bpasero
Copy link
Member

bpasero commented Aug 31, 2016

I think also the vscode-icons theme does not show them and it seems to be OK.

@isidorn
Copy link
Contributor Author

isidorn commented Aug 31, 2016

Yes, but the vscode-icons shows the same icon for all file types so it would be just noise. But in the seti theme I feel like the icons would bring value in the open editors view

@aeschli aeschli assigned bpasero and unassigned aeschli Aug 31, 2016
@bpasero
Copy link
Member

bpasero commented Aug 31, 2016

If we do this we need to start adding settings so that a user can decide. We also might need this for tabs.

As far as I know, the vscode-icons extension does NOT show icons for "opened editors".

@bpasero bpasero removed their assignment Aug 31, 2016
@bpasero bpasero added this to the Backlog milestone Aug 31, 2016
@robertohuertasm
Copy link
Contributor

Hi @bpasero, @isidorn. vscode-icons does currently support tabs and "open editors" icons. I was under the impression, after talking with @aeschli by email that this was somehow on the roadmap. I fully understand that this is not going to be released by Sept 12th but I thought that it was more or less to be released by October.

I'm willing to avoid code injection but I would like to keep users with a similar functionality if possible.

@robertohuertasm
Copy link
Contributor

@isidorn I think you're confusing vscode-icons with the new standard icons provided by the new icons extension point. Check out this

@bpasero
Copy link
Member

bpasero commented Oct 3, 2016

This is in for September, closing.

@bpasero bpasero closed this as completed Oct 3, 2016
@bpasero bpasero self-assigned this Oct 3, 2016
@bpasero bpasero modified the milestones: September 2016, Backlog Oct 3, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Development

No branches or pull requests

4 participants