Adds support for gulpfiles using ESM. #113505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Node versions support ECMAScript modules beside the classic CommonJS modules. This means gulp does so too. So we endup with three entry points: The legacy gulfile.js and the new gulpfile.cjs as well as gulpfile.mjs. When using only ESM or the ESM package, gulp suggest: Rename 'gulpfile.js' to 'gulpfile.esm.js'
|
|
alexr00
approved these changes
Jan 6, 2021
| @@ -70,21 +89,23 @@ function showError() { | |||
| } | |||
|
|
|||
| async function findGulpCommand(rootPath: string): Promise<string> { | |||
There was a problem hiding this comment.
While I cannot deny that the refactoring here is clearer, it's easier/faster/less cognitive load to review PRs that don't include refactors and features together. The greater the number of lines changed, the less likely I am to get to it quickly (and I know I'm not alone on that :))
|
I'm using VSCode Insiders and this error started appearing a few days ago while running tasks.
Note that I do not use gulp. The output tab logs: I'm not sure if this PR is relevant but wanted to report it. |
|
Thank you @andreialecu for reporting this! Not the first time it would have been good to have some linter error for checking truthiness of a promise. Fixed with bebd066 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Node versions support ECMAScript modules beside
the classic CommonJS modules.
This means gulp does so too. So we endup with three entry points:
The legacy gulfile.js and the new gulpfile.cjs as well as gulpfile.mjs.
When using only ESM or the ESM package, gulp suggest:
Rename 'gulpfile.js' to 'gulpfile.esm.js'. This entry point is also added.
For more details refer to https://github.com/gulpjs/gulp#use-latest-javascript-version-in-your-gulpfile
This PR fixes #