Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] re-saving an open file that was deleted does not remove the (deleted) marker #113781

Closed
asklar opened this issue Jan 4, 2021 · 8 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone

Comments

@asklar
Copy link
Member

asklar commented Jan 4, 2021

  • VSCode Version: 1.51.1
  • OS Version: Windows 10 21265

Steps to Reproduce:

  1. open a file in vscode
  2. delete the file outside vscode. Note that vscode correctly shows a the string "(deleted)" in the tab name.
  3. re-save the file. The tab title does not get updated.
  4. Switch to another tab and then back, the tab title gets updated.

Does this issue occur when all extensions are disabled?: Yes/No

@vscodebot
Copy link

vscodebot bot commented Jan 4, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero bpasero self-assigned this Jan 5, 2021
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-editors Managing of editor widgets in workbench window labels Jan 5, 2021
@bpasero
Copy link
Member

bpasero commented Jan 5, 2021

Can someone else try to reproduce?

@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Jan 5, 2021
@bpasero
Copy link
Member

bpasero commented Jan 6, 2021

recording

Does not reproduce for me.

@bpasero bpasero added the info-needed Issue requires more information from poster label Jan 6, 2021
@asklar
Copy link
Member Author

asklar commented Jan 6, 2021

vscode_refresh

@bpasero
Copy link
Member

bpasero commented Jan 7, 2021

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@jeanp413
Copy link
Contributor

jeanp413 commented Jan 7, 2021

This happens for a file that is outside of the currently opened workspace folder, in the above gift package.json is in a parent folder of the MidIRT workspace folder

@bpasero bpasero removed help wanted Issues identified as good community contribution opportunities info-needed Issue requires more information from poster labels Jan 7, 2021
@bpasero bpasero added this to the January 2021 milestone Jan 7, 2021
@bpasero
Copy link
Member

bpasero commented Jan 7, 2021

Ah thanks for clarifying. Yes, we currently do not detect when a file comes back for files outside of the workspace because that would mean we had to watch pretty much the entire disk. But I pushed a fix to clear the "deleted" upon successful save.

@bpasero bpasero closed this as completed in 578c3d5 Jan 7, 2021
@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Jan 19, 2021
@github-actions
Copy link

This bug has been fixed in to the latest release of VS Code Insiders!

@asklar, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version eaa959d of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@RMacfarlane RMacfarlane added the verified Verification succeeded label Jan 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Development

No branches or pull requests

5 participants
@bpasero @RMacfarlane @asklar @jeanp413 and others