Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybinding: Allow colon to be a valid keybinding #114

Closed
jpoon opened this issue Nov 18, 2015 · 2 comments
Closed

Keybinding: Allow colon to be a valid keybinding #114

jpoon opened this issue Nov 18, 2015 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@jpoon
Copy link

jpoon commented Nov 18, 2015

Working on a VIM extension. A core key binding of VIM is :.

The below is a workaround:

     {
        "key": "Shift+;",
        "command": "extension.vimMode_colon",
        "when": "editorTextFocus"
      },

but it doesn't work on international keyboards.

@alexdima
Copy link
Member

@jpoon I can't really add support for that. The keybinding dispatching occurs in a keydown browser event handler, where I only get the keyCode and the modifiers state (i.e. keyboard layout independent, not what would be produced in a keypress).

We need to do something special for vim mode where all typed characters can be "trapped" and redirected to an extension

@alexdima alexdima added the feature-request Request for new features or functionality label Nov 25, 2015
@alexdima
Copy link
Member

@jpoon We cannot add colon as a valid keybinding for now. Please see #713 where the problem is explained. I also suggest #713 as the tracking issue instead of having an issue for each individual desired keybinding character.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants