Fix: add alwaysConsumeMouseWheel for list #114182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I was testing something out and expected the "update branch" button to not immediately act. Shouldn't change anything. |
|
@joaomoreno Hi, do you got chance to review this? |
|
@joaomoreno Hi, got time for this? |
|
Sorry @susiwen8, I'll make sure this goes in the February release. |
joaomoreno
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
@jrieken Changes are good, tested them myself. So if the behavioral change is good for you, let's merge this in.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #113389
Add
alwaysConsumeMouseWheelforList