Improve glob module to support OS separator agnostic matching #114810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #114794 I found that while the pattern
**a/file/**will matcha/fileon both windows and mac, the patterna/filewill matcha/fileon Mac but onlya\fileon windows. This seems counter to most all of the other glob matches, so to me looks like a bug.We could go even further and allow
a/fileto match botha\fileanda/fileon both mac and windows, which again seems consistant with the other globs (see commented out test cases), not sure if that's desired. It'd likely result in a bit worse performance.