alexr00/issue115337 #115537
Merged
alexr00/issue115337 #115537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
reviewed
Feb 1, 2021
| @@ -259,7 +259,7 @@ export class IconLabel extends Disposable { | |||
| }; | |||
| IconLabel.adjustXAndShowCustomHover(hoverOptions, mouseX, hoverDelegate, isHovering); | |||
|
|
|||
| const resolvedTooltip = await tooltip(tokenSource.token); | |||
| const resolvedTooltip = (await tooltip(tokenSource.token)) ?? (!isString(markdownTooltip) ? markdownTooltip.markdownNotSupportedFallback : undefined); | |||
| if (resolvedTooltip) { | |||
There was a problem hiding this comment.
Is it intentional that it will not work when the empty string is returned? Wouldn't it then still show "Loading..."?
There was a problem hiding this comment.
Good catch, yes it will still show "Loading...". I think in this case we should simply hide the hover since none was provided.
bpasero
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
I think this is better now. A follow up item is maybe to not just have a generic hideHover method but correlate the operation to an identifier. Now it seems we are resolving a hover (which can take a long time) and then eventually might call hideHover even though I maybe opened another hover. I wonder if this could accidentally close a different hover.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115337