Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest VS Code (1.53.0) breaks debug configs #115916

Closed
TCourtneyOwen opened this issue Feb 5, 2021 · 5 comments
Closed

Latest VS Code (1.53.0) breaks debug configs #115916

TCourtneyOwen opened this issue Feb 5, 2021 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@TCourtneyOwen
Copy link

We noticed after upgrading to VS Code 1.53.0 that our launch.json debug configs no longer work. Our debug configs invoke tasks defined in tasks.json.

Our launch.json config is as follows:

{
  "name": "Excel Desktop (Edge Chromium)",
  "type": "edge",
  "request": "attach",
  "useWebView": "advanced",
  "port": 9229,
  "timeout": 600000,
  "webRoot": "${workspaceRoot}",
  "preLaunchTask": "Debug: Excel Desktop",
  "postDebugTask": "Stop Debug"
},

And the prelaunchTask is defined in tasks.json as follows:

{
  "label": "Debug: Excel Desktop",
  "type": "npm",
  "script": "start:desktop -- --app excel",
  "presentation": {
    "clear": true,
    "panel": "dedicated",
  },
  "problemMatcher": []
},

When we try to initiate the Excel Desktop (Edge Chromium) debug config, we get the following error:

Executing task: npm run "start:desktop -- --app excel" <

npm ERR! missing script: start:desktop -- --app excel

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\cowen\AppData\Roaming\npm-cache_logs\2021-02-05T00_02_33_429Z-debug.log
The terminal process "C:\WINDOWS\System32\cmd.exe /d /c npm run "start:desktop -- --app excel"" terminated with exit code: 1.

The problem doesn't look to be with the task in task.json as we can invoke this separately with no problems. Rather it appears to be an issue with the interaction between our launch.json config and tasks.json, presumably with the preLaunchTask option in launch.json.

We use these debug configs extensively in our project templates for Microsoft Office Add-in projects. These templates are used by many, many customers of Microsoft so we will surely hear from some of them in the near future when they encounter this issue.

I work on the Microsoft Office Platform Extensibility team, so please feel free to reach out to me for more information.

Thanks,

Courtney Owen
SWE, OPX Team

@roblourens
Copy link
Member

Sounds related to #115876

@roblourens
Copy link
Member

roblourens commented Feb 5, 2021

Unless it's different because

The problem doesn't look to be with the task in task.json as we can invoke this separately with no problems. Rather it appears to be an issue with the interaction between our launch.json config and tasks.json, presumably with the preLaunchTask option in launch.json.

But I don't know why there would be a difference in how the task is invoked by itself vs as part of a launch config

@xmedeko
Copy link
Contributor

xmedeko commented Feb 6, 2021

Try to convert task type npm to shell, see #115876 (comment)

@alexr00
Copy link
Member

alexr00 commented Feb 8, 2021

This is indeed a duplicate of #115876

@alexr00 alexr00 added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

6 participants
@roblourens @xmedeko @connor4312 @TCourtneyOwen @alexr00 and others