Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any SSH File system extension will crash VS Code in a similar way - Buffer() is deprecated @ console.ts:137 #116260

Closed
Simba98 opened this issue Feb 10, 2021 · 6 comments
Assignees
Labels
electron Issues and items related to Electron freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders upstream-issue-fixed The underlying upstream issue has been fixed
Milestone

Comments

@Simba98
Copy link

Simba98 commented Feb 10, 2021

  • VS Code Version & OS Version:
    VS Code Version: 1.53.1 (user setup)
    Submit: 5d424b8
    Date: 2021-02-08T23:29:42.785Z
    Electron: 11.2.1
    Chrome: 87.0.4280.141
    Node.js: 12.18.3
    V8: 8.7.220.31-electron.0
    OS: Windows_NT x64 10.0.19042
    Steps to Reproduce:
  1. Install a SSH File System extension.
  2. Try to connect it, and the extension will launch SSH.
  3. VS Code will crash. I tried SSH FS, SSH Client, they are popular extensions, and all of them will crash VS Code in a similar way.
  4. I opened the developer tool, as following shows.
    image
    The copyright of this file shows it belongs to Microsoft code.
  5. Here is the console message.
    image
    (node:15060) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    b @ console.ts:137

Does this issue occur when all extensions are disabled?: No, but I still guess this issue due to VS code. Because I tried several SSH extensions, and all have similar problem.

@Simba98
Copy link
Author

Simba98 commented Feb 10, 2021

A call stack has been tracked and as the following screenshot shows.
image

@Simba98
Copy link
Author

Simba98 commented Feb 10, 2021

Moreover, I tried to downgrade VS Code, crash disappeared.

I downgrade to:
Version: 1.52.1 (user setup)
Submit: ea3859d
date: 2020-12-16T16:34:46.910Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19042

@3b0b
Copy link

3b0b commented Feb 11, 2021

I suspect this is a duplicate of #114362, which has some notes on what's been found regarding the underlying problem in Electron 11

@alexr00
Copy link
Member

alexr00 commented Feb 11, 2021

@scriptninja thanks for dropping that link in.

@deepak1556 it seems like this is likely caused by an electron 11 issue: electron/electron#27673

@alexr00 alexr00 assigned deepak1556 and unassigned alexr00 Feb 11, 2021
@deepak1556 deepak1556 added electron Issues and items related to Electron electron-11-update freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues upstream-issue-fixed The underlying upstream issue has been fixed labels Feb 11, 2021
@deepak1556 deepak1556 added this to the February 2021 milestone Feb 11, 2021
@deepak1556
Copy link
Contributor

Thanks for the issue pointer, the fix will be backported to the electron 11 branch and will get it into our next release.

@MJimitater
Copy link

This issue seems fixed. However, I got a similar error message (-1617863769299.zip), but Im not working with any SSH file system extension. How does this relate?

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders upstream-issue-fixed The underlying upstream issue has been fixed
Projects
None yet
Development

No branches or pull requests

6 participants
@3b0b @deepak1556 @Simba98 @MJimitater @alexr00 and others