Cell output metadata to be added to Notebook Model #116968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Feb 18, 2021
| const resource = await createRandomFile('', undefined, '.vsctestnb'); | ||
| await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest'); | ||
| assert.strictEqual(vscode.window.activeNotebookEditor !== undefined, true, 'notebook first'); | ||
| assert.strictEqual(vscode.window.activeNotebookEditor!.selection?.document.getText(), 'test'); | ||
| assert.strictEqual(vscode.window.activeNotebookEditor!.selection?.language, 'typescript'); | ||
|
|
||
| const secondCell = vscode.window.activeNotebookEditor!.document.cells[1]; | ||
| assert.strictEqual(secondCell!.outputs.length, 1); | ||
| assert.deepStrictEqual(secondCell!.outputs[0].metadata, { testOutputMetadata: true }); |
There was a problem hiding this comment.
This was failing.
DonJayamanne
commented
Feb 18, 2021
| @@ -1466,7 +1466,9 @@ export namespace NotebookCellData { | |||
| source: data.source, | |||
| metadata: data.metadata, | |||
| outputs: data.outputs.map(output => ({ | |||
| outputId: output.id, outputs: (output.outputs || []).map(op => ({ | |||
| outputId: output.id, | |||
| metadata: output.metadata, | |||
There was a problem hiding this comment.
This is what was missing
rebornix
requested changes
Feb 18, 2021
| @@ -65,7 +65,7 @@ async function withEvent<T>(event: vscode.Event<T>, callback: (e: Promise<T>) => | |||
| await callback(e); | |||
| } | |||
|
|
|||
| suite('Notebook API tests', function () { | |||
| suite.only('Notebook API tests', function () { | |||
There was a problem hiding this comment.
Make sure .only is not checked in when merging the PR.
jrieken
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
Thanks. Change look OK but there is some uglyness in needing to change so many tests. We have plans to write them more pretty so expect some further changes soon. Also, for the future, esp wrt notebook document suff, you could add your tests into notebook.document.test.ts (which tries to be a little more modern)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes ##116967