Enable setTextDocumentLanguage #119429
Merged
Enable setTextDocumentLanguage #119429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
reviewed
Mar 23, 2021
src/vs/workbench/contrib/notebook/browser/viewModel/notebookViewModel.ts
Outdated
Show resolved
Hide resolved
|
I think I'm getting it. Currently only the cell view model knows about the Also any issue with giving it to the cell text model here instead of listening on model creation events? |
Exactly.
I don't think that's a good place. It feels like an awkward coupling to me and it would also not take care of documents that get closed |
roblourens
force-pushed
the
roblou/languageModel
branch
2 times, most recently
from
de2d391
to
12d0e04
Compare
roblourens
commented
Mar 29, 2021
src/vs/workbench/contrib/notebook/browser/viewModel/baseCellViewModel.ts
Show resolved
Hide resolved
roblourens
force-pushed
the
roblou/languageModel
branch
from
12d0e04
to
0846ad5
Compare
jrieken
reviewed
Mar 31, 2021
src/vs/workbench/contrib/notebook/browser/viewModel/markdownCellViewModel.ts
Outdated
Show resolved
Hide resolved
roblourens
force-pushed
the
roblou/languageModel
branch
from
22f53c1
to
3b39462
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #117936
When a TextModel is created, we set it on the cell VM which listens to language updates on it until it's disposed. The NotebookCellTextModel can still get a language set on it, and the TextModel will take that language when it's initialized.