Replace -1 constant in keycode with enum value #120126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tthe key code logic uses the constant `-1` in a number of places. With the latest TS 4.3 nightly build, this causes a compile error since there is no overlap between `-1` and the `KeyCode` enum This change adds a `-1` value to the `KeyCode` and `ScanCode` enums
|
@alexdima I am merging this to unblock updating to TS 4.3. Please let me know if you have any concerns about this change. Feel free to rename the new enum value too |
|
👍 Looks Good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tthe key code logic uses the constant
-1in a number of places. With the latest TS 4.3 nightly build, this causes a compile error since there is no overlap between-1and theKeyCodeenumThis change adds a
-1value to theKeyCodeandScanCodeenumsmicrosoft/TypeScript#43419