Make splitting respect supportMultipleDocument #120263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have updated the behavior to move the editor to the new group if it doesn't support splitting. As for the case of it being by itself in the group, I'm not sure what the best behavior to do there or if there is one. |
|
@mjbvz After discussion during the UX sync it seems like the consensus here is to create an empty group if splitting is not allowed. This PR has been updated to reflect that. |
mjbvz
approved these changes
Apr 7, 2021
digitarald
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Make splitting respect supportMultipleDocument * Make split move the unsupported editor in the direction of the split * Make it always split an empty group if the editor doesn't support splitting
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Apr 8, 2021
* Make splitting respect supportMultipleDocument * Make split move the unsupported editor in the direction of the split * Make it always split an empty group if the editor doesn't support splitting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #119666
When a custom editor is split that doesn't support multiple document it is left behind and a new empty group is created in the direction of split. This behavior aligns with what happens if your
supportSplitEditorsflag is false.