Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inactive tab title color look different from active tab when decorations are visible #120345

Closed
fernandopsilveira opened this issue Apr 1, 2021 · 9 comments
Assignees
Labels
feature-request Request for new features or functionality file-decorations themes Color theme issues workbench-tabs VS Code editor tab issues

Comments

@fernandopsilveira
Copy link

Now that lint errors are reflected on tab title foreground color, it's much more harder to me to find the active tab, since inactive tabs title foreground color do not get darkened.

Please, make inactive tab title color look different when it reflects lint status.

@fernandopsilveira
Copy link
Author

Nope. I was talking about linting status, not git status, but anyway...
I don't want to disable it, I'm suggesting an improvement

@bpasero
Copy link
Member

bpasero commented Apr 2, 2021

@fernandopsilveira to clarify, you refer to the tab color for when an error or warning is present in the file of a tab? Can you post a screenshot of where you find it hard to distinguish inactive from active tab then?

@bpasero bpasero added the info-needed Issue requires more information from poster label Apr 2, 2021
@fernandopsilveira
Copy link
Author

fernandopsilveira commented Apr 4, 2021

Without tab decorations (easy to find active tab)
001

With tab decorations (not so easy to find active tab, since there's no color difference)
002

(badges are disabled)

@bpasero bpasero added file-decorations themes Color theme issues workbench-tabs VS Code editor tab issues and removed info-needed Issue requires more information from poster labels Apr 5, 2021
@bpasero bpasero assigned jrieken and unassigned bpasero Apr 5, 2021
@bpasero bpasero changed the title make inactive tab title color look different from active tab Make inactive tab title color look different from active tab when decorations are visible Apr 5, 2021
@jrieken jrieken added this to the Backlog Candidates milestone Apr 6, 2021
@jrieken jrieken added the feature-request Request for new features or functionality label Apr 6, 2021
@dancherb
Copy link

dancherb commented Apr 6, 2021

lint errors are reflected on tab title foreground color

How can we disable or customise this behaviour completely? It's really obstructive in some cases, particularly depending on theme.

tab active error foreground

@fernandopsilveira
Copy link
Author

@dancherb, you can easily disable editor decorations on VSCode settings:

image

lint errors are reflected on tab title foreground color

How can we disable or customise this behaviour completely? It's really obstructive in some cases, particularly depending on theme.

tab active error foreground

@bpasero
Copy link
Member

bpasero commented Apr 6, 2021

I think this needs a similar fix as was done with #43179 where colors for list decorations were introduced.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-decorations themes Color theme issues workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

5 participants
@bpasero @fernandopsilveira @jrieken @dancherb and others