Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: update js-debug #120358

Merged
merged 1 commit into from Apr 5, 2021
Merged

Conversation

connor4312
Copy link
Member

@connor4312 connor4312 commented Apr 1, 2021

This fixes #120227 and contains the following change: microsoft/vscode-js-debug@2994e05

On WSL, calling listen(x) preferentially listened on ipv6 loopback. Interestingly, while listening on :: and connecting on ipv4 loopback seem to work if everything is in Windows, if the server is running in WSL you can only connect via ::, where the companion tries to attach on 127.0.0.1.

# wsl:

> net.createServer().listen(0).address()
{ address: '::', family: 'IPv6', port: 10556 }
> net.connect(36715, '127.0.0.1', l => console.log("ok"))
ok

# windows:

> net.connect(36715, '127.0.0.1', l => console.log("ok"))
Error: connect ECONNREFUSED 127.0.0.1:36715
> net.connect(36715, '::', l => console.log("ok"))
ok

So the change was to go back to the old behavior (before I refactored things for the port listener) to explicitly listen on 127.0.0.1. More secure anyway in the event that listen(x) binds to anycast.

@connor4312 connor4312 added the candidate Issue identified as probable candidate for fixing in the next release label Apr 1, 2021
@connor4312 connor4312 added this to the March 2021 Recovery milestone Apr 1, 2021
@connor4312 connor4312 self-assigned this Apr 1, 2021
@connor4312 connor4312 merged commit d6e72b4 into release/1.55 Apr 5, 2021
@connor4312 connor4312 deleted the connor4312/1-55-remote-debug-candidate branch April 5, 2021 05:54
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants