Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5 Quick Open never finishes and Activity Monitor shows high CPU #12047

Closed
jpconsi opened this issue Sep 14, 2016 · 8 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@jpconsi
Copy link

jpconsi commented Sep 14, 2016

  • VSCode Version: 1.5.2
  • OS Version: Max OSX 10.11.5

Steps to Reproduce:

  1. In Visual Studio Code editor, Command P. Type in a file to search for. It searches but never finishes.
  2. Open Activity Monitor and it shows find using high cpu 80% and Code Helper using 120%.
  3. Have to force quit find and Code Helper in order to recover.

Note: In prior versions I was using Command E and it worked great. In version 1.5.1 that was taken away so I had to start using Command P and it has never worked the same.

image

@chrmarti chrmarti added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 15, 2016
@chrmarti
Copy link
Contributor

@jpconsi There is a performance regression in 1.5.x when there are large excluded folders which is fixed with #11874 in the 'insiders' build. Let me know if that fixes it if you get a chance to give the insiders build a try.

Might also be a combination of issues you see, marking as duplicate of #11963.

@jpconsi
Copy link
Author

jpconsi commented Oct 3, 2016

I tried code insider 1.6.0 and it still consumes heavy cpu and never finishes. See below screen shot
image

image

@jpconsi
Copy link
Author

jpconsi commented Oct 3, 2016

Ran this command: time (find -L . -type f|wc -l); echo $?
3572161

real 6m6.056s
user 0m5.891s
sys 1m49.988s

The above was with regular VS Code.

Below is with Insider VS Code. Note, I have no excluded files defined user settings on the VS Code Insider.

time (find -L . -type f | wc -l); echo $?
9700987

real 9m37.093s
user 0m13.694s
sys 3m26.524s

@jpconsi
Copy link
Author

jpconsi commented Oct 3, 2016

Here is a screen shot of a search for "auth"
image

@chrmarti
Copy link
Contributor

chrmarti commented Oct 3, 2016

@jpconsi Thanks for letting me know. Did you run the time (find ...) commands while in your project's folder? It tells us how many files are in your current folder and the two numbers (3.5 millions vs. 9.7 millions) are not the same.

@jpconsi
Copy link
Author

jpconsi commented Oct 3, 2016

Reading the other post. I ran ps aux| grep of the code helper that was taking high cpu. Found that it was fileWatcher. I had already had many files paths excluded. This is my final version that seems to be keeping CodeHelper (fileWatcher) from running over 100% cpu. Originally, I had "/node_modules":true I find that it does not work. I had to add ** at the end as shown in the below example. :/node_modules/*":true For some reason when I post this it removes the *. So you need the ** before node_modules and after node_modules. Do this for for all folders you want to exclude.

"files.watcherExclude": {
"/node_modules/": true,
"/node-server/": true,
"/*.js": true,
"
/.js.map": true,
"/tmp/": true,
"/dist/": true,
"__/
.config": true,
"/*.css" : true,
"
/.svg" : true,
"__/
.scss" : true,
"/*.json" : true,
"
/.d.ts" : true,
"v1.0/tmp/" : true,
"
/.git": true,
"__/.hg": true,
"
*/.DS_Store": true
},

@jpconsi
Copy link
Author

jpconsi commented Oct 3, 2016

@chrmarti I did not realize what the time (find ... thing was doing) I have multiple projects so I ran that on any project I was in. Below is the largest project.

9700987
real 9m20.653s
user 0m12.609s
sys 3m4.477s

@chrmarti
Copy link
Contributor

chrmarti commented Oct 3, 2016

What do your "files.exclude" and "search.exclude" settings look like? "files.watcherExclude" is only applied to the automatic pick-up of changes on disk, not the QuickOpen functionality.

Btw., you can use single backticks to include the patterns within text and tripple backticks to include the patterns as a block. (See Code tab: https://guides.github.com/features/mastering-markdown/#examples)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants