Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-120578 don't offer callstack step-in/over/out when not stopped #120581

Merged
merged 2 commits into from Apr 6, 2021

Conversation

gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Apr 5, 2021

This PR fixes #120578

After this change, when running:

image

When stopped:

image

@gjsjohnmurray
Copy link
Contributor Author

/assign @isidorn

@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented Apr 5, 2021

Improved so the step-buttons get disabled rather than hidden. This means that the pause/continue button remains in the same position.

image

@isidorn
Copy link
Contributor

isidorn commented Apr 6, 2021

Love this fix ❤️ . Thanks a lot 👏

@isidorn isidorn merged commit d491ec5 into microsoft:main Apr 6, 2021
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Apr 6, 2021
@isidorn isidorn added this to the April 2021 milestone Apr 6, 2021
@gjsjohnmurray gjsjohnmurray deleted the fix-120578 branch April 6, 2021 16:45
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug Call Stack inline step-in/over/out commands are always enabled
2 participants