Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve terminal tabs + button #120960

Closed
meganrogge opened this issue Apr 9, 2021 · 1 comment · Fixed by #121704
Closed

Improve terminal tabs + button #120960

meganrogge opened this issue Apr 9, 2021 · 1 comment · Fixed by #121704
Assignees
@meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues terminal-tabs
Milestone
April 2021

Comments

@meganrogge
Copy link
Contributor

See #120878 (comment)
@meganrogge meganrogge added polish Cleanup and polish issue terminal Integrated terminal issues labels Apr 9, 2021
@meganrogge meganrogge added this to the April 2021 milestone Apr 9, 2021
@meganrogge meganrogge self-assigned this Apr 9, 2021
@meganrogge meganrogge mentioned this issue Apr 9, 2021
Merged
@eamodio
Copy link
Contributor

eamodio commented Apr 14, 2021 •
edited

IMO the + button is too close to the terminal tabs and its heigh doesn't match the others so it looks kind of visually off to me. It also only gets focus feedback after the menu is dismissed. It should also have hover feedback as well.

I would also love to see the + button be a split button or something, where you can open a new default terminal in a single click, and only open the menu if you want to select a different one

This was referenced Apr 17, 2021
Closed
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues terminal-tabs
Projects
None yet
Milestone
April 2021
4 participants
@eamodio @Tyriar @meganrogge and others